[pkg/stanza] SplitFunc naming cleanup #26631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-split-func-factory
branch
4 times, most recently
from
62ff0b2 to
a4ef388
Compare
| @@ -26,6 +26,6 @@ func NewCustomFactory(splitFunc bufio.SplitFunc, flushPeriod time.Duration) Fact | |||
| } | |||
|
|
|||
| // Build builds Multiline Splitter struct | |||
| func (f *customFactory) Build() (bufio.SplitFunc, error) { | |||
There was a problem hiding this comment.
comments should also be updated to SplitFunc
| } | ||
| } | ||
|
|
||
| // Build builds Multiline Splitter struct | ||
| func (f *multilineFactory) Build() (bufio.SplitFunc, error) { |
| factory := NewMultilineFactory(tt.multilineCfg, tt.encoding, tt.maxLogSize, trim.Nop, tt.flushPeriod) | ||
| got, err := factory.Build() | ||
| factory := NewSplitFuncFactory(tt.splitConfig, tt.encoding, tt.maxLogSize, trim.Nop, tt.flushPeriod) | ||
| got, err := factory.SplitFunc() | ||
| if (err != nil) != tt.wantErr { | ||
| t.Errorf("Build() error = %v, wantErr %v", err, tt.wantErr) |
djaglowski
force-pushed
the
pkg-stanza-split-func-factory
branch
from
a4ef388 to
15ab4ad
Compare
|
Thanks for the review @fatsheep9146. I've updated the comments. |
fatsheep9146
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another few remaining parts of #26241. This basically follows up on renaming the
multilinepackage by renaming a few remaining to "multiline" throughout the codebase.